fix(accessibility): fix wrong mic/camera instructions #450

khushi19099 · 2025-05-09T08:59:39Z

Summary
This PR fixes accessibility issues in the microphone and speaker controls in the meeting widgets. It corrects incorrect screen reader labels and improves keyboard navigation instructions for a more inclusive user experience.

Related Issue
JIRA: SPARK-564420 – Screen Readers: Label includes incorrect instructions

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

Proposed Changes

Added aria-labelledby attributes pointing to the visible
Removed misleading hint properties from mic and speaker switch controls
Refactored speaker options control to better support keyboard users

Screenshots / Demo

AccessibilityScreenRecording.mov

Testing Done
✅ Verified correct label announcements using screen readers (VoiceOver, NVDA)

✅ Tested seamless dropdown navigation via keyboard

✅ Ensured no regression for mouse and touch inputs

✅ Checklist

My code follows the code style of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (if applicable)
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

✅ GAI Checklist

I have not used any generative AI tool to write code I do not understand
I have reviewed and validated all AI-assisted code suggestions
I confirm that the changes comply with the team's GAI usage guidelines
I have documented significant AI contributions where applicable

coderabbitai · 2025-05-09T08:59:45Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes in this pull request update the version of the @webex/components dependency in the package.json file from 1.277.0 to 1.277.1. No other dependencies, configurations, or exported entities were modified.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (1)

package.json (1)
35-36: Consider using caret ranges for consistency.

Other @webex/* dependencies use caret (^) version ranges. To maintain consistency in versioning, consider changing
"@webex/components": "1.277.1"
to
- "@webex/components": "1.277.1"
+ "@webex/components": "^1.277.1"
unless pinning is intentional.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e68e1f9 and d3c6a20.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

package.json (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: setup_test_release

🔇 Additional comments (3)

package.json (3)

1-157: Mismatch between PR objectives and changed files.

The PR description indicates accessibility fixes for mic/camera instructions, but this diff only updates package.json dependencies — no UI or accessibility-related code is modified. Please confirm whether the correct files were included or if additional changes are pending.

Likely an incorrect or invalid review comment.

38-38: New sass dependency addition seems appropriate.

Switching from node-sass to Dart Sass (sass) aligns with modern best practices and avoids native binding issues. Ensure your Webpack or Rollup config (e.g., sass-loader) is set to use Dart Sass.

39-39: Switching to caret range for webex is good.

Allowing patch updates on webex ("^2.60.4") will help in staying up-to-date with bug fixes and security patches.

package.json

sreenara

@khushi19099 please change the description of the PR to follow the PULL_REQUEST_TEMPLATE.md file.

Shreyas281299

We should just be upgrading @webex/components -> 1.277.1
The testing video is still of the story book, can you test in the meetings widget with the new components version
Check coderabbits comments, they seem valid

Shreyas281299 · 2025-05-13T04:32:36Z

package.json

-    "webex": "2.60.4",
-    "@webex/components": "1.277.0"
+    "@webex/widgets": "^1.28.0",
+    "sass": "^1.87.0",


Are we moving to sass from node-sass? Since this is just accesibility change, we should avoid updating a version. We would need to check the whole widgets to ensure this upgrade is not breaking anything else.

package.json

This reverts commit d3c6a20.

…ctions

khushi19099 · 2025-05-19T06:33:56Z

Changes have been updated

…github.com/khushi19099/widgets into fix/accessibility-fixed-wrong-instructions

sreenara · 2025-05-28T04:47:37Z

🎉 This PR is included in version 1.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [1.28.1](webex/widgets@v1.28.0...v1.28.1) (2025-05-28) ### Bug Fixes * **accessibility:** fix wrong mic/camera instructions ([webex#450](webex#450)) ([ff88612](webex@ff88612))

fix(accessibility): fix wrong mic/camera instructions

d3c6a20

coderabbitai bot reviewed May 9, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

sreenara requested changes May 9, 2025

View reviewed changes

Shreyas281299 requested changes May 13, 2025

View reviewed changes

khushi19099 added 3 commits May 19, 2025 06:16

Revert "fix(accessibility): fix wrong mic/camera instructions"

702a1f5

This reverts commit d3c6a20.

dependencies updates reverted back

5cf1812

Merge branch 'webex:master' into fix/accessibility-fixed-wrong-instru…

6fa3e91

…ctions

khushi19099 added 3 commits May 21, 2025 08:32

fix(accessibility): installation/build done

26b5fbf

Merge branch 'fix/accessibility-fixed-wrong-instructions' of https://…

7ed25bc

…github.com/khushi19099/widgets into fix/accessibility-fixed-wrong-instructions

fix(accessibility): installation/build done

1bab07a

Shreyas281299 approved these changes May 22, 2025

View reviewed changes

sreenara approved these changes May 27, 2025

View reviewed changes

Shreyas281299 merged commit ff88612 into webex:master May 28, 2025
2 checks passed

sreenara added the released label May 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(accessibility): fix wrong mic/camera instructions #450

fix(accessibility): fix wrong mic/camera instructions #450

Uh oh!

khushi19099 commented May 9, 2025 •

edited by sreenara

Loading

Uh oh!

coderabbitai bot commented May 9, 2025 •

edited

Loading

Review skipped

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sreenara left a comment

Uh oh!

Shreyas281299 left a comment •

edited

Loading

Uh oh!

Shreyas281299 May 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khushi19099 commented May 19, 2025

Uh oh!

Uh oh!

sreenara commented May 28, 2025

Uh oh!

Uh oh!

fix(accessibility): fix wrong mic/camera instructions #450

fix(accessibility): fix wrong mic/camera instructions #450

Uh oh!

Conversation

khushi19099 commented May 9, 2025 • edited by sreenara Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

✅ Checklist

✅ GAI Checklist

Uh oh!

coderabbitai bot commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sreenara left a comment

Choose a reason for hiding this comment

Uh oh!

Shreyas281299 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Shreyas281299 May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khushi19099 commented May 19, 2025

Uh oh!

Uh oh!

sreenara commented May 28, 2025

Uh oh!

Uh oh!

khushi19099 commented May 9, 2025 •

edited by sreenara

Loading

coderabbitai bot commented May 9, 2025 •

edited

Loading

Shreyas281299 left a comment •

edited

Loading