chore(pipeline): persist dist for all cc folders #360
Conversation
WalkthroughThe pull request modifies the CircleCI configuration file to use a wildcard pattern for persisting build artifacts from the contact-center packages. Instead of explicitly listing individual package distribution directories, the configuration now uses a more flexible approach that automatically captures all Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.circleci/config.yml (1)
68-69: LGTM! The change improves maintainability.The modification to use a wildcard pattern
packages/contact-center/*/distis a good improvement because:
- It automatically includes all contact-center package dist folders
- Reduces configuration maintenance when adding new packages
- Keeps the configuration DRY
Consider documenting this pattern in the repository's README or contributing guidelines to ensure future contributors understand the automatic inclusion of new contact-center packages.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.circleci/config.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: setup_test_release
🔇 Additional comments (1)
.circleci/config.yml (1)
68-69: Verify CircleCI wildcard pattern support.The wildcard pattern
packages/contact-center/*/distis more maintainable than listing individual paths. However, let's verify that CircleCI supports this pattern for workspace persistence.✅ Verification successful
CircleCI wildcard patterns are correct and supported ✓
The patterns correctly match all buildable packages:
packages/contact-center/*/distcovers all 5 contact-center subpackagespackages/@webex/widgets/distcorrectly targets the webex widgets package🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of contact-center packages with dist folders # and ensure we're not missing any in the new pattern # Find all contact-center packages with dist folders echo "Contact center packages with dist folders:" fd --type d --glob 'packages/contact-center/*/dist' # List package.json files to verify build configurations echo -e "\nVerifying build configurations in package.json files:" fd --type f --glob 'packages/contact-center/*/package.json' --exec cat {} \; | grep -A 5 '"build":'Length of output: 376
Script:
#!/bin/bash # Check the actual directory structure echo "Directory structure under packages:" fd --max-depth 2 . packages/ echo -e "\nAll package.json files under packages:" fd package.json packages/ echo -e "\nAll dist directories under packages:" fd --type d dist packages/Length of output: 895
|
🎉 This PR is included in version 1.28.0-ccwidgets.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.28.0-ccconnectors.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes Adhoc
This PR addresses
by making the following changes
Summary by CodeRabbit