Skip to content

Conversation

rajeshtezu
Copy link
Contributor

@rajeshtezu rajeshtezu commented Oct 4, 2022

COMPLETES #<SPARK-359114>

This pull request addresses

Adds a property waitingForOthersToJoin to check if others has joined or not and could be utilised to show actual remote video, hide it or show a custom banner.

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@rajeshtezu rajeshtezu requested a review from a team as a code owner October 4, 2022 14:48
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2456.d3m3l2kee0btzx.amplifyapp.com

Copy link
Collaborator

@arun3528 arun3528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good we will need some tests and a wiki with basic info

@rajeshtezu rajeshtezu marked this pull request as draft October 6, 2022 05:32
@rajeshtezu rajeshtezu marked this pull request as ready for review October 6, 2022 06:33
@rajeshtezu
Copy link
Contributor Author

Code looks good we will need some tests and a wiki with basic info

Added unit tests and Wiki

@arun3528 arun3528 merged commit 20684a7 into webex:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants