Skip to content

set appPlatform before storing if SDK is provided + update SDK, components, adapter #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2022
Merged

set appPlatform before storing if SDK is provided + update SDK, components, adapter #1219

merged 3 commits into from
Mar 8, 2022

Conversation

taymoork2
Copy link
Member

@taymoork2 taymoork2 commented Feb 23, 2022 •
edited
Loading

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1219.d1l3lxgizk4iez.amplifyapp.com

jonniespratley
jonniespratley approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@jonniespratley jonniespratley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified nice.

lalli-flores
lalli-flores reviewed Feb 23, 2022
View reviewed changes
@lalli-flores lalli-flores marked this pull request as draft February 25, 2022 18:14
@taymoork2 taymoork2 changed the title set appName and appVersion before storing if SDK is provided set appLabel before storing if SDK is provided Mar 1, 2022
@taymoork2 taymoork2 changed the title set appLabel before storing if SDK is provided set appPlatform before storing if SDK is provided Mar 2, 2022
@taymoork2 taymoork2 changed the title set appPlatform before storing if SDK is provided set appPlatform before storing if SDK is provided + update SDK, components, adapter Mar 2, 2022
@taymoork2 taymoork2 marked this pull request as ready for review March 7, 2022 18:39
@taymoork2 taymoork2 requested a review from jonniespratley March 7, 2022 18:43
@lalli-flores lalli-flores merged commit 8933f85 into webex:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalli-flores lalli-flores lalli-flores approved these changes

@jonniespratley jonniespratley Awaiting requested review from jonniespratley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taymoork2 @jonniespratley @lalli-flores