Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new EsLint rules #9445

Merged
merged 6 commits into from
Dec 24, 2022
Merged

Adding new EsLint rules #9445

merged 6 commits into from
Dec 24, 2022

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Dec 24, 2022

Proposed changes

After reviewing #9124 we encountered a lot of review cycles that could have been prevented by setting these two eslint rules: eqeqeq, prefer-const, consistent-type-imports and dot-notation. This patch enforces these coding conventions so we can review more efficient next time.

Types of changes

  • Improving internal coding conventions
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Dec 24, 2022
@christian-bromann christian-bromann changed the title Cb eslint improvements Adding new EsLint rules Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants