Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@wdio/cucumber-framework): disable parallel execution and warn user that this feature is not supported #11099

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

christian-bromann
Copy link
Member

Proposed changes

Disable the parallel execution of Cucumber as it is currently not supported.

refs #11078

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

I wonder if we should rather fail the test run instead of just printing a warning in the logs that might could get overseen.

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Sep 5, 2023
@christian-bromann
Copy link
Member Author

@tamil777selvan what do you think is the better option here:

  • forcing the parallel option to be 0 and print a warning message (which might can get overseen by the user)
  • throwing an error if parallel option is being used

I am tending towards the second.

@tamil777selvan
Copy link
Member

@tamil777selvan what do you think is the better option here:

  • forcing the parallel option to be 0 and print a warning message (which might can get overseen by the user)
  • throwing an error if parallel option is being used

I am tending towards the second.

Hi @christian-bromann Second option, sounds good to me.

@christian-bromann christian-bromann merged commit 4a31a60 into main Sep 5, 2023
@christian-bromann christian-bromann deleted the cb-no-cucumber-parallel branch September 5, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants