Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@wdio/utils): ignore space before new line when detecting local Chrome version #11019

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #11018

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 25, 2023
@lararojasmr
Copy link
Contributor

Nice, thanks. I was about to create a PR for this haha. Thanks!

@christian-bromann christian-bromann merged commit fdf1484 into main Aug 25, 2023
@christian-bromann christian-bromann deleted the cb-local-chrome-detection branch August 25, 2023 21:19
@christian-bromann
Copy link
Member Author

Ah damn .. I usually encourage folks to submit a PR but for some reasons I just picked this one up immediately since you've described the bug very well. Will make a release now. If you are interested contributing I am happy to help you find something!

@lararojasmr
Copy link
Contributor

Thank you for the quick response! No worries at all – I'm glad the bug description was clear and helpful. I'm definitely interested in contributing further. Just let me know how I can be of assistance or if there's a particular area you'd like me to dive into. Looking forward to collaborating more!

@lararojasmr
Copy link
Contributor

@christian-bromann ☝🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
2 participants