Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new article: Guide for Cross Platform E2E Test For Native Mobile APP #10486

Merged
merged 21 commits into from
Jun 2, 2023

Conversation

amrsa1
Copy link
Contributor

@amrsa1 amrsa1 commented Jun 1, 2023

Proposed changes

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 1, 2023

CLA Missing ID CLA Not Signed

@amrsa1 amrsa1 changed the title Add new article:Guide for Cross Platform E2E Test For Native Mobile APP Add new article: Guide for Cross Platform E2E Test For Native Mobile APP Jun 1, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great article! The extra line breaks and horizontal lines should not be needed, let's remove them.

amrsa1 and others added 2 commits June 2, 2023 09:12
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

amrsa1 and others added 2 commits June 2, 2023 09:17
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amrsa1 can we move all images of this blog post into a dedicated folder?

Comment on lines 268 to 270

-------->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment saying that the full workflow can be viewed at the end of the article

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Co-authored-by: Christian Bromann <git@bromann.dev>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

1 similar comment
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@amrsa1 amrsa1 changed the title Add new article: Guide for Cross Platform E2E Test For Native Mobile APP Add new article : Guide for Cross Platform E2E Test For Native Mobile APP Jun 2, 2023
@amrsa1 amrsa1 changed the title Add new article : Guide for Cross Platform E2E Test For Native Mobile APP Add new article: Guide for Cross Platform E2E Test For Native Mobile APP Jun 2, 2023
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jun 2, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great article, thanks for the write-up. Would love to have more content like this on the blog.

@christian-bromann christian-bromann merged commit 948d9a2 into webdriverio:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants