Skip to content

Conversation

@webdevred
Copy link
Owner

@webdevred webdevred commented Sep 21, 2025

  • Added assocWithPrior to InternalComment
  • Updated Jbeam Parsing, Transformation and Formatting to typecheck and use the new field
  • Updated AST dumps to verify the the comments get treated correctly
  • Added tests for new functionality

@webdevred webdevred force-pushed the associate-comments-without-newline-before-with-prior-node branch from f867ca9 to eccf7d1 Compare September 21, 2025 19:37
@webdevred webdevred force-pushed the associate-comments-without-newline-before-with-prior-node branch from 4f1afa2 to 27b2db9 Compare September 21, 2025 21:37
@webdevred webdevred merged commit 9c0bff1 into master Sep 21, 2025
13 checks passed
@webdevred webdevred deleted the associate-comments-without-newline-before-with-prior-node branch September 21, 2025 21:43
This was referenced Oct 2, 2025
webdevred added a commit that referenced this pull request Oct 5, 2025
Updated examle files to showcase how the recent changes to Transformation code affect jbeam. The major changes to transformation code are in #69

The changes to transformation which are related to this new example files are the following:

- Transformation reimplemenation: before errors were handled less safely and meta groups interrupting vertex groups was not supported #2
- Transformation refactoring: split Transformation into different files and added improved how comments and metadata is handled when moving vertices #41
- Support vertex detection: implemented detection of support vertices and automatically moving them to their own tree  #52
- Associate comments without newline before with prior node #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant