Force complex newline property #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webdevred
force-pushed
the
master
branch
5 times, most recently
from
d0f5d6d to
386379a
Compare
webdevred
force-pushed
the
force-complex-newline-property
branch
2 times, most recently
from
64b7335 to
8973d84
Compare
* Consider children if any of them are singleline comments * Avoid newlines before object keys
webdevred
force-pushed
the
force-complex-newline-property
branch
from
1f7b20f to
0c8e99b
Compare
webdevred
force-pushed
the
force-complex-newline-property
branch
from
091de22 to
5df2915
Compare
This is needed because when complexChildren is False singleline comments are not terminated
- Introduced `charBoth` in `Helpers.hs` to combine two `Char -> Bool` predicates. - Simplified `isNotFinalChar` in `Helpers.hs` using `charBoth`. - Refactored object key parser in `DSL.hs` to use `charBoth`. - Removed unnecessary parentheses in `Formatting.hs` for `newlineBeforeComment`.
webdevred
force-pushed
the
force-complex-newline-property
branch
from
e969779 to
b701f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectKey & NodeCursor refactor
maybeObjectKeyfor extracting object-key text fromObjectKeynodes.applyObjCrumb;applyCrumbnow usesmaybeObjectKeyto generateObjectIndexAndKeybreadcrumbs.NodeCursorandcompareSBto handle the new breadcrumb structure.selectandfindAndUpdateTextInNodelogic usingmaybeObjectKey.ObjectKeynodes to no longer require special crumb logic.ForceComplexNewLine feature
ForceComplexNewLine :: PropertyKey Boolin formatting rules.forceComplexNewLinefunction to check this property for aNodeCursor.doFormatNodeto respectforceComplexNewLinewhen formatting nodes.ForceComplexNewLineproperty in input files.CommandLineOptions cleanup
foldl' (>>=)withfoldr (=<<)when applying option actions.