Distinguish mysql.filter into white- and blacklist #103
Conversation
src/config.ini
Outdated
| typo3[] = "/^tx_extensionmanager_.*/i" | ||
| all[] = "/^.*$/i" | ||
|
|
||
| typo3caching[] = "/^cachingframework_.*/i" |
There was a problem hiding this comment.
My intension was to give this filter group a more meaningful name, because it's not "typo3" tables the user wants to exclude from transferring, it's only the "typo3 caching" tables. For other scenarios it might come in handy to just define "typo3news" tables or whatever.
There was a problem hiding this comment.
But then doesn't all clisync.yml files in the project has to be changed? There is a filter setting which is currently set to typo3 instead of typo3caching
There was a problem hiding this comment.
Well that's probably true. On the other hand there would be an error that "typo3" cannot be found and an update to the clisync.yml is necessary. Shall I change it back?
kitzberger
changed the title
|
@mblaschke : I worked on this feature a little again, fixed some bugs, made it more stable and all. The old 'filter' is still working as a fallback for the new (imho more intuitively labeled) 'blacklist'. I'd appreciate if you'd take a look and test it. I think it'll be a great addition to the syncing/backuping commands. |
|
@kitzberger conflicts :) |
…ist-blacklist Conflicts: src/app/CliTools/Console/Command/Mysql/BackupCommand.php src/app/CliTools/Console/Command/Sync/AbstractCommand.php
|
Can't see any ;-) |
2 participants
Added a whitelist filter to mysqldump commands and therefore renamed "filter" to "blacklist".
It's possible to use both filters at the same time: any table not matching the whitelist is put onto the ignoredTables array, plus any table matching the blacklist.
Should any set mysql.filter argument trigger an exception? To inform the user to update their clisync.yml?
Any discussion / opinion / thought regarding this is highly appreciated!