Update TypeScript and upstream internal changes. #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding the "Skip Changelog" label as this PR has no user-observable changes. |
bicknellr
commented
Sep 22, 2022
bicknellr
commented
Sep 22, 2022
…` type, not the built-in type.
|
Hmm, I'm gonna go back to draft. |
bicknellr
commented
Sep 22, 2022
|
Internal tests of the new polyfills including this PR passed so I think this is ready for review now. (custom elements: http://cl/475617405, webcomponentsjs: http://cl/475619724) |
rictic
approved these changes
Oct 4, 2022
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams a couple of internal CLs that added
anyin a few places to make this code compatible with a newer version of TypeScript (4.4 I think?). The PR then updates TypeScript to the latest version and makes other type changes to work with that version.