Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo that prevents the document construction observer from being created. #283

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

bicknellr
Copy link
Collaborator

This ! was accidentally removed during the TS conversion and causes elements in the main document not to be upgraded.

…flag. (...)

This flag was accidentally flipped in 98a5a6d, causing parser-created elements
in the main document not to be constructed.
Copy link
Contributor

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@bicknellr bicknellr merged commit 86c5cb1 into master Mar 12, 2020
@bicknellr bicknellr deleted the ce-construction-observer-flag branch March 12, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants