Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.google.com – Time is cropped on “Popular times” graphic #7356

Closed
softvision-oana-arbuzov opened this issue Jun 9, 2017 · 4 comments
Labels
browser-firefox-mobile type-GWS-interop Google properties interoperability testing type-GWS-interop-tracked Google properties interoperability testing type-uaoverride Require a UA override for working
Milestone

Comments

@softvision-oana-arbuzov
Copy link
Member

URL: https://google.com
Browser / Version: Firefox Mobile Nightly 55.0a1 (2017-06-09) - Chome UA
Operating System: LG G5 (Android 7.0) - Resolution 1440 x 2560 pixels (~554 ppi pixel density)
Problem type: Text is not visible

Steps to Reproduce

  1. Navigate to: https://goo.gl/AEYj2R.
  2. Scroll down to “Popular times” graphic.
  3. Observe time displayed.

Expected Behavior:
Time is fully displayed.

Actual Behavior:
Time is cropped.

Note:

  1. Not reproducible on Chrome (Mobile) 58.0.3029.83, on Firefox 53.0.2 Release and Firefox Nightly 55.0a1 (2017-06-05) without Chrome UA.
  2. Screenshot attached.

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov

sv; gs

Screenshot Description

From webcompat.com with ❤️

@softvision-oana-arbuzov softvision-oana-arbuzov changed the title google.com - text is not visible www.google.com – Time is cropped on “Popular times” graphic Jun 9, 2017
@karlcow
Copy link
Member

karlcow commented Jun 19, 2017

The time is defined by

<div style="" class="i_NOYJDb5a6c-17AgC1q3TaA _epj">
    <div>
        <div class="_ipj">
            <div>6a</div>
        </div>
    </div>
    <div></div>
    <div></div>
    <div>
        <div class="_ipj">
            <div>9a</div>
        </div>
    </div>
    <div></div>
    <div></div>

<!-- cut for brevity -->
</div>

but there is a block for the full graphic.

Screenshot Description

which is defined by

<div class="_ppj i_NOYJDb5a6c-JjrbqILQZ8E" 
     data-ved="0ahUKEwiTlabcm8nUAhWBUrwKHVXxCE8QoWEIYTAN" 
     style="height: 135px;">

<!-- cut -->

</div>

and has a fixed height.

if I change the height to be 141px we can finally see the full block.
note also that the blocks for time are set with

Screenshot Description

._ipj {
	height: 18px;
	position: relative;
	-webkit-user-select: none;
	white-space: nowrap;
}

It's why the pink doesn't go full in the red outline and a combination of line-height.

all in all the design is not very robust depending on font-size etc.
And I'm not sure again we can do anything here on Gecko side.

setting as contactready but not really made for contact as of now.

@karlcow karlcow added the type-uaoverride Require a UA override for working label Aug 15, 2017
@miketaylr miketaylr added the type-GWS-interop Google properties interoperability testing label Oct 25, 2017
@karlcow karlcow added this to the contactready milestone Oct 30, 2017
@miketaylr
Copy link
Member

setting as contactready but not really made for contact as of now.

@karlcow what would the suggested fix be in this case? It seems like an interop issue around font line-height? Or did I misunderstand.

@karlcow
Copy link
Member

karlcow commented Nov 1, 2017

line-height: normal or 1.2 would fix the design in Firefox and breaks it in Chrome, because Roboto and Open Sans have different features. I need to write an article about this.
https://bugzilla.mozilla.org/show_bug.cgi?id=1392147

@wisniewskit
Copy link
Member

While the symptom here seems slightly different (a line-height:normal or line-height:<number> value), it appears to be yet another case of the text-descender interop issues I made bug 1406552 to investigate. That issue may in turn be related to the ones in #8753.

There is also another case of usage of "Roboto-Regular" instead of "Roboto", which only further complicates the issue as Firefox mobile is likely selecting Clear Sans instead of Roboto, which is being investigated by Blink here.

@webcompat-bot webcompat-bot modified the milestones: contactready, duplicate Dec 7, 2017
@stephenmcgruer stephenmcgruer added the type-GWS-interop-tracked Google properties interoperability testing label Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile type-GWS-interop Google properties interoperability testing type-GWS-interop-tracked Google properties interoperability testing type-uaoverride Require a UA override for working
Projects
None yet
Development

No branches or pull requests

6 participants