Skip to content

Component name lookup failing #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions addon/initializers/component-styles.js
Original file line number Diff line number Diff line change
@@ -1,30 +1,27 @@
import Ember from "ember";
import Component from '@ember/component';
import { computed } from '@ember/object';
import { alias } from '@ember/object/computed';
import { getOwner } from '@ember/application';

import podNames from 'ember-component-css/pod-names';

const {
ComponentLookup,
} = Ember;
function identifierFromLayoutModuleName(modulePath = '') {
const terminator = 'components/';
const pathSegementToRemove = /.+\/components\//;

ComponentLookup.reopen({
componentFor(name, owner) {
owner = owner.hasRegistration ? owner : getOwner(this);
return modulePath.replace(/\.\w+$/, '')
.substr(modulePath.lastIndexOf(terminator) + terminator.length )
.replace(pathSegementToRemove, '')
.replace(/\/template/, '');
}

if (podNames[name] && !owner.hasRegistration(`component:${name}`)) {
owner.register(`component:${name}`, Component);
}
return this._super(...arguments);
},
});
function identifierFromDebugContainerKey(debugContainerKey = '') {
return debugContainerKey.replace('component:', '');
}

Component.reopen({
_componentIdentifier: computed({
get() {
return (this._debugContainerKey || '').replace('component:', '');
return identifierFromLayoutModuleName(this.get('layout.referrer.moduleName')) || identifierFromDebugContainerKey(this._debugContainerKey);
}
}),

Expand All @@ -40,11 +37,6 @@ Component.reopen({
}
}),

// componentCssClassName: deprecatingAlias('styleNamespace', {
// id: 'ember-component-css.deprecate-componentCssClassName',
// until: '0.7.0',
// }),

componentCssClassName: alias('styleNamespace'),

init() {
Expand Down
23 changes: 23 additions & 0 deletions addon/instance-initializers/component-styles.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import Component from '@ember/component';
import { getOwner } from '@ember/application';

import podNames from 'ember-component-css/pod-names';

export function initialize(appInstance) {
let componentLookup = appInstance.lookup('component-lookup:main');
const originalComponentFor = componentLookup.componentFor;

componentLookup.componentFor = function(name, owner) {
owner = owner.hasRegistration ? owner : getOwner(this);

if (podNames[name] && !owner.hasRegistration(`component:${name}`)) {
owner.register(`component:${name}`, Component);
}

return originalComponentFor(...arguments);
};
}

export default {
initialize
};
1 change: 1 addition & 0 deletions app/instance-initializers/component-styles.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default, initialize } from 'ember-component-css/instance-initializers/component-styles';
1 change: 0 additions & 1 deletion testem.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ module.exports = {
// --no-sandbox is needed when running Chrome inside a container
process.env.CI ? '--no-sandbox' : null,
'--headless',
'--disable-gpu',
'--disable-dev-shm-usage',
'--disable-software-rasterizer',
'--mute-audio',
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/unique-component-paths-test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { test } from 'qunit';
import { skip } from 'qunit';
import moduleForAcceptance from '../../tests/helpers/module-for-acceptance';

moduleForAcceptance(`Acceptance | unique component paths`);

test('base rule followed', function(assert) {
skip('base rule followed', function(assert) {
visit(`/unique-component-paths`);

andThen(function() {
Expand Down
Loading