Skip to content

SignatureProvider implementation #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

odanylovych
Copy link

Hi.

This is the second PR, it is related to signature providers. The first one is #446.

We are working on the Avalanche library and in order to integrate this library we need to be able to use custom signature provider which should be asynchronous. One of the benefits of asynchronous signature providers is the ability to add support for hardware wallets for example.

In this PR:

  • We created SignatureProvider protocol which returns accounts and performs signing of transactions and messages asynchronously.
  • Implemented default KeystoreSignatureProvider which uses AbstractKeystore.
  • Specific implementation of signature provider can be set in web3 object.

If you need more info, please, tell us. Will be glad to provide it.

Thanks.

@yaroslavyaroslav yaroslavyaroslav self-requested a review March 17, 2022 14:59
@yaroslavyaroslav
Copy link
Collaborator

@odanylovych it takes a while, but now we're done. So if you still have an effort to add your PR to, I'll be happy to support in any way. Sorry for it took so long and for we've broke almost everything.

And please keep in mind, that's for now we're having REST only network layer.

@yaroslavyaroslav
Copy link
Collaborator

I'll close it for now, just as I said in another PR, please feel free to reopen it when you'll be ready to give us a try once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants