- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.1k
 
newPendingTransactionFilter #7353
Conversation
          Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total 
 Changeset
 View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger 
 Smaller No assets were smaller Unchanged 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
| Benchmark suite | Current: 0f6b7e2 | Previous: 69d83e7 | Ratio | 
|---|---|---|---|
processingTx | 
22604 ops/sec (±7.04%) | 
22353 ops/sec (±7.82%) | 
0.99 | 
processingContractDeploy | 
40356 ops/sec (±6.61%) | 
37636 ops/sec (±7.55%) | 
0.93 | 
processingContractMethodSend | 
16677 ops/sec (±7.31%) | 
15415 ops/sec (±6.99%) | 
0.92 | 
processingContractMethodCall | 
27823 ops/sec (±8.03%) | 
28129 ops/sec (±6.61%) | 
1.01 | 
abiEncode | 
45377 ops/sec (±7.67%) | 
42413 ops/sec (±7.80%) | 
0.93 | 
abiDecode | 
30035 ops/sec (±7.81%) | 
30494 ops/sec (±7.44%) | 
1.02 | 
sign | 
1495 ops/sec (±0.63%) | 
1487 ops/sec (±3.26%) | 
0.99 | 
verify | 
351 ops/sec (±0.57%) | 
364 ops/sec (±0.46%) | 
1.04 | 
This comment was automatically generated by workflow using github-action-benchmark.
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##              4.x    #7353      +/-   ##
==========================================
+ Coverage   94.50%   94.51%   +0.01%     
==========================================
  Files         217      218       +1     
  Lines        8495     8557      +62     
  Branches     2347     2363      +16     
==========================================
+ Hits         8028     8088      +60     
- Misses        467      469       +2     
 Flags with carried forward coverage won't be shown. Click here to find out more.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great documentation 🙏🏻 Just one question.
Description
#7188
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.