Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test error "project ID request rate exceeded" #7290

Merged

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Sep 30, 2024

Description

Some tests were failing because of the old block was using. I've changed to the latest finalized block.

image image

Link to the GithubAction tests

Tests results with new endpoints

Fixes #7284

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Sep 30, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.81 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.32 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 48bff04 Previous: adf483f Ratio
processingTx 21845 ops/sec (±8.07%) 22201 ops/sec (±6.45%) 1.02
processingContractDeploy 38618 ops/sec (±5.59%) 38668 ops/sec (±7.43%) 1.00
processingContractMethodSend 15645 ops/sec (±9.34%) 15754 ops/sec (±8.04%) 1.01
processingContractMethodCall 28255 ops/sec (±6.20%) 26952 ops/sec (±7.86%) 0.95
abiEncode 42626 ops/sec (±7.73%) 41355 ops/sec (±6.79%) 0.97
abiDecode 31152 ops/sec (±6.27%) 29853 ops/sec (±6.08%) 0.96
sign 1559 ops/sec (±0.98%) 1523 ops/sec (±3.43%) 0.98
verify 361 ops/sec (±0.90%) 360 ops/sec (±0.74%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (adf483f) to head (48bff04).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7290   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2339     2339           
=======================================
  Hits         7993     7993           
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdevcs
Copy link
Contributor

jdevcs commented Oct 2, 2024

PR lgtm, requested some minor changes

@avkos
Copy link
Contributor Author

avkos commented Oct 3, 2024

@avkos avkos merged commit 76c468a into 4.x Oct 4, 2024
54 checks passed
@avkos avkos deleted the ok/7284-Fix-e2e-test-error-project-ID-request-rate-exceeded- branch October 4, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix e2e test error "project ID request rate exceeded"
3 participants