Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix padRight validation failure on large uint #7265

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #7182

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Sep 18, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.67 kB → 640.69 kB (+25 B) +0.00%
Changeset
File Δ Size
../web3-utils/lib/commonjs/string_manipulation.js 📈 +37 B (+0.61%) 5.91 kB → 5.95 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 621.26 kB → 621.29 kB (+25 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0f33f43 Previous: d6baee6 Ratio
processingTx 22502 ops/sec (±7.20%) 20672 ops/sec (±7.40%) 0.92
processingContractDeploy 38484 ops/sec (±5.62%) 39409 ops/sec (±5.84%) 1.02
processingContractMethodSend 16043 ops/sec (±6.31%) 14911 ops/sec (±8.22%) 0.93
processingContractMethodCall 27304 ops/sec (±5.87%) 26166 ops/sec (±9.05%) 0.96
abiEncode 42863 ops/sec (±7.24%) 41338 ops/sec (±7.20%) 0.96
abiDecode 29941 ops/sec (±7.18%) 29000 ops/sec (±6.11%) 0.97
sign 1495 ops/sec (±3.48%) 1518 ops/sec (±3.68%) 1.02
verify 366 ops/sec (±0.65%) 365 ops/sec (±0.65%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (d6baee6) to head (0f33f43).
Report is 3 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7265   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2338     2339    +1     
=======================================
  Hits         7992     7992           
  Misses        471      471           
Flag Coverage Δ
UnitTests 94.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Muhammad-Altabba Muhammad-Altabba merged commit aa471e7 into 4.x Sep 24, 2024
54 checks passed
@Muhammad-Altabba Muhammad-Altabba deleted the 7182-web3utilspadright-cannot-pad-hex-strings-that-begin-with-0x8-or-higher branch September 24, 2024 14:07
@luu-alex luu-alex mentioned this pull request Oct 16, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3.utils.padRight cannot pad hex strings that begin with 0x8 or higher
4 participants