-
Notifications
You must be signed in to change notification settings - Fork 5.1k
v4 Tests - Testing time only Github action config #6732
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6732 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 214 214
Lines 8171 8171
Branches 2200 2200
=======================================
Hits 7520 7520
Misses 651 651
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
| Latest commit: |
fd56a0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccae0c0d.web3-js-docs.pages.dev |
| Branch Preview URL: | https://ok-6686-v4-tests---testing-t-7k16.web3-js-docs.pages.dev |
This reverts commit 74744a7.
|
Improvements I've applied:
My investigations to decrease test time:
this option switched off type checking in tests which decreases processing time. In our case, it is just 1-5 seconds. That is why I’ve decided not to use this option. |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6686
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.