Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Check failing tests (estimate gas problem) #6702

Merged
merged 11 commits into from
Jan 15, 2024

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Jan 8, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6685

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jan 8, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 618 KB 618 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 601 KB 601 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

Copy link

github-actions bot commented Jan 8, 2024

Benchmark

Benchmark suite Current: f0a78c3 Previous: 6c075db Ratio
processingTx 9143 ops/sec (±4.22%) 9301 ops/sec (±4.81%) 1.02
processingContractDeploy 36436 ops/sec (±12.48%) 39129 ops/sec (±7.62%) 1.07
processingContractMethodSend 18433 ops/sec (±8.35%) 19443 ops/sec (±5.19%) 1.05
processingContractMethodCall 38434 ops/sec (±6.74%) 38971 ops/sec (±6.34%) 1.01
abiEncode 44068 ops/sec (±8.21%) 44252 ops/sec (±6.92%) 1.00
abiDecode 31076 ops/sec (±8.48%) 30419 ops/sec (±8.89%) 0.98
sign 1626 ops/sec (±3.75%) 1656 ops/sec (±4.08%) 1.02
verify 381 ops/sec (±0.60%) 373 ops/sec (±0.78%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f0a78c3
Status: ✅  Deploy successful!
Preview URL: https://214360fa.web3-js-docs.pages.dev
Branch Preview URL: https://ok-6685-v4-tests---check-fai.web3-js-docs.pages.dev

View logs

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Merging #6702 (f0a78c3) into 4.x (3cfe56f) will not change coverage.
Report is 1 commits behind head on 4.x.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6702   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         214      214           
  Lines        8171     8171           
  Branches     2200     2200           
=======================================
  Hits         7520     7520           
  Misses        651      651           
Flag Coverage Δ
UnitTests 92.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@avkos
Copy link
Contributor Author

avkos commented Jan 8, 2024

Investigation results
current contract data
geth http 480435n
geth ws 480435n
ganache http 475494n
ganache ws 475494n

Simple contract data
geth http 174646n
geth ws 174646n
ganache http 172113n
ganache ws 172113n

So different EVMs return different estimated gas values.

@avkos avkos changed the title Check failing tests (estimate gas problem) [DRAFT] Check failing tests (estimate gas problem) Jan 8, 2024
@avkos avkos merged commit 5161642 into 4.x Jan 15, 2024
@avkos avkos deleted the ok/6685-v4-Tests---Check-failing-tests branch January 15, 2024 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 Tests - Check failing tests
4 participants