Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jan 4, 2024

Description

#6260

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@jdevcs jdevcs added the 4.x 4.0 related label Jan 4, 2024
@github-actions
Copy link

github-actions bot commented Jan 4, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 618 KB 618 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 601 KB 601 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@github-actions
Copy link

github-actions bot commented Jan 4, 2024

Benchmark

Benchmark suite Current: 03fe131 Previous: 6c075db Ratio
processingTx 9450 ops/sec (±3.43%) 9301 ops/sec (±4.81%) 0.98
processingContractDeploy 39075 ops/sec (±7.27%) 39129 ops/sec (±7.62%) 1.00
processingContractMethodSend 19015 ops/sec (±8.75%) 19443 ops/sec (±5.19%) 1.02
processingContractMethodCall 39248 ops/sec (±6.05%) 38971 ops/sec (±6.34%) 0.99
abiEncode 42971 ops/sec (±7.38%) 44252 ops/sec (±6.92%) 1.03
abiDecode 29663 ops/sec (±9.40%) 30419 ops/sec (±8.89%) 1.03
sign 1662 ops/sec (±0.72%) 1656 ops/sec (±4.08%) 1.00
verify 373 ops/sec (±2.60%) 373 ops/sec (±0.78%) 1

This comment was automatically generated by workflow using github-action-benchmark.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 03fe131
Status: ✅  Deploy successful!
Preview URL: https://378c66d5.web3-js-docs.pages.dev
Branch Preview URL: https://junaid-v4enstutorial.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #6687 (03fe131) into 4.x (2a40b66) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6687   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         214      214           
  Lines        8171     8171           
  Branches     2200     2200           
=======================================
  Hits         7472     7472           
  Misses        699      699           
Flag Coverage Δ
UnitTests 91.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@luu-alex
Copy link
Contributor

luu-alex commented Jan 8, 2024

Other than a grammar change and capitalization LGTM

Co-authored-by: Alex  <alex.luu@mail.utoronto.ca>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4.x 4.0 related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants