-
Notifications
You must be signed in to change notification settings - Fork 5.1k
v1/chore(web3-eth-accounts): bump @ethereumjs/common and @ethereumjs/tx #6457
Conversation
0843f17 to
23f0474
Compare
23f0474 to
4289f4c
Compare
jdevcs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dnt merge external PRs with following changes:
-
dist/ build output
-
package-lock files, ( If changes in packagelock are necessary thn one of our team member will do these in another PR )
48e9316 to
4289f4c
Compare
|
Hi @legobeat |
Yes: To get the updates done in the updates in |
Muhammad-Altabba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @legobeat for your contribution,
Description
The versions of
@ethereumjs/dependencies were pinned in #5529.This retains the pin (uncertain why it was first introduced) but bumps them to latest within semver-major.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.1.xbranch.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.