-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fillInputData
option argument to formatTransaction
on call
function in rpc_method_wrappers
#6378
Conversation
add `{fillInputAndData: true,}` to `eth_call` on method_wrappers
fillInputData
option argument to on call
function on rpc_method_wrappersfillInputData
option argument to formatTransaction
on call
function in rpc_method_wrappers
Hey there @moshmage do you have an code snippet you can share of how your using this code? it'll help me out a ton :) |
sure @luu-alex -- head over to https://github.com/moshmage/dappkit/blob/3.x.x/test/models/base-model.spec.ts#L59 (where it fails the test): the You can read how to set-up a dev-env on https://github.com/moshmage/dappkit/blob/3.x.x/how-to/contributing/readme.md ps: The way I got to the "fill input data was" that I just echoed out the json params that |
Thanks alot this is really helpful! We are actually trying to get away from using the default call to be both I'll be adding to the PR so that you can use a flag when creating your contract to include in your method calls to either send |
Being fair to hardhat, the only place where That said, as long as web3js plays ball with hardhat it'll be cool by me; But I'm afraid that this change will add a "we will deal with any and all edge-cases" precedent and I don't wanna be the cause for it :P Wouldn't it be better if we go to the |
I understand, i'm not too sure why the geth documentation and eth official docs are different but we have been trying hard to follow the geth repo as much as possible. I think your suggestion is great! It will be included as a web3config. |
Description
The
fillInputData
option onformatTransaction
call that was introduced with this change lefteth_call
method unchanged. In my case,4.1.0 + hardhat
was unable to call a simpleERC20.name()
returningunkown function selector
(even if the contract had a fallback).Adding this argument to the function call when
call()
is made fixed it on my side.Type of change