add inner error to errors on send 6300 #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
722706a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3520f3e4.web3-js-docs.pages.dev |
| Branch Preview URL: | https://add-inner-error-metamask.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6350 +/- ##
==========================================
+ Coverage 89.07% 89.10% +0.03%
==========================================
Files 199 199
Lines 7717 7722 +5
Branches 2125 2127 +2
==========================================
+ Hits 6874 6881 +7
+ Misses 843 841 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
luu-alex
requested review from
avkos,
jdevcs and
Muhammad-Altabba
as code owners
avkos
approved these changes
Aug 14, 2023
|
LGTM, please add test coverage |
|
@avkos fixed, thanks |
jdevcs
reviewed
Aug 15, 2023
jdevcs
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6300
Error objects that are returned from an RPC is not included in the error, making it an issue if a user wanted to keep track of this. For example when cancelling a send transaction on metamask, metamask will send back an error and code but we currently do not include that in the error. This PR adds the error Object to be apart of the innerError property.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.