-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inner error to errors on send 6300 #6350
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6350 +/- ##
==========================================
+ Coverage 89.07% 89.10% +0.03%
==========================================
Files 199 199
Lines 7717 7722 +5
Branches 2125 2127 +2
==========================================
+ Hits 6874 6881 +7
+ Misses 843 841 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LGTM, please add test coverage |
@avkos fixed, thanks |
Description
#6300
Error objects that are returned from an RPC is not included in the error, making it an issue if a user wanted to keep track of this. For example when cancelling a send transaction on metamask, metamask will send back an error and code but we currently do not include that in the error. This PR adds the error Object to be apart of the innerError property.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.