Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction input and data refactors #6294

Merged
merged 15 commits into from
Aug 3, 2023
Merged

Transaction input and data refactors #6294

merged 15 commits into from
Aug 3, 2023

Commits on Jul 19, 2023

  1. Remove extra formatting check for input and data for transactionSchema

    @spacesailor24
    spacesailor24 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5c65103 View commit details
    Browse the repository at this point in the history

  2. Update transaciton builder to only use input or data provided by user… 

    …, don't autofill unless both or nullish
    @spacesailor24
    spacesailor24 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7a5b5ca View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Add check for transaction.data for getEthereumjsTxDataFromTransaction

    @spacesailor24
    spacesailor24 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7412abe View commit details
    Browse the repository at this point in the history

  2. Update PopulatedUnsignedBaseTransaction to have optional input and da… 

    …ta properties
    @spacesailor24
    spacesailor24 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    9d56a31 View commit details
    Browse the repository at this point in the history

  3. Update sign_transaction test

    @spacesailor24
    spacesailor24 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ee074e6 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOGs

    @spacesailor24
    spacesailor24 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2f03bb7 View commit details
    Browse the repository at this point in the history

  5. Merge branch '4.x' into wyatt/4.x/6183-input-data-refactor

    @spacesailor24
    spacesailor24 authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f32feb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge branch '4.x' into wyatt/4.x/6183-input-data-refactor

    @spacesailor24
    spacesailor24 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    a5b195d View commit details
    Browse the repository at this point in the history

  2. Add fillInputAndData option to formatTransaction. Make options.transa… 

    …ctionSchema optional with transactoinInfoSchema the default value
    @spacesailor24
    spacesailor24 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    24ae148 View commit details
    Browse the repository at this point in the history

  3. Update tests

    @spacesailor24
    spacesailor24 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    19023ea View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOGs

    @spacesailor24
    spacesailor24 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1b0b30d View commit details
    Browse the repository at this point in the history

  5. Convert formattedTransaction. input and data to hex string before com… 

    …paring equality for TransactionDataAndInputError check
    @spacesailor24
    spacesailor24 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    df836d5 View commit details
    Browse the repository at this point in the history

  6. Update test fixtures

    @spacesailor24
    spacesailor24 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e75e379 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Add options.fillInputAndData to decodeSignedTransaction

    @spacesailor24
    spacesailor24 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    a4ca37c View commit details
    Browse the repository at this point in the history

  2. Update sign_transaction fixture data

    @spacesailor24
    spacesailor24 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d82de1a View commit details
    Browse the repository at this point in the history