Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix estimateGas to accept hex data without 0x prefix #6103

Merged
merged 11 commits into from
May 22, 2023

Conversation

nikoulai
Copy link
Contributor

Description

closes #6088

@github-actions
Copy link

github-actions bot commented May 18, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 645 KB 645 KB 61 bytes 0.01%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 628 KB 628 KB 61 bytes 0.01%
../lib/commonjs/index.d.ts 8.43 KB 8.43 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.37 KB 2.37 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 808 bytes 808 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24cac5a
Status: ✅  Deploy successful!
Preview URL: https://8f840b4e.web3-js-docs.pages.dev
Branch Preview URL: https://nikos-6088-estimategas-throw.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #6103 (24cac5a) into 4.x (8c3a17b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6103   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         199      199           
  Lines        7612     7614    +2     
  Branches     2063     2065    +2     
=======================================
+ Hits         6654     6656    +2     
  Misses        958      958           
Flag Coverage Δ
UnitTests 87.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the unit test to increase coverage?

@jdevcs
Copy link
Contributor

jdevcs commented May 19, 2023

also some tests needs to be fixed

web3-eth-contract:   1 failing
web3-eth-contract:   1) contract
web3-eth-contract:        defaults
web3-eth-contract:          should use "defaultAccount" on "instance" level instead of "from":
web3-eth-contract:       AssertionError: expected 142780n to equal 'Any BigInt'

@djrann13 djrann13 linked an issue May 20, 2023 that may be closed by this pull request
@djrann13 djrann13 removed a link to an issue May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling estimateGas throws 'out-of-gas error', if the data does not start with '0x'
4 participants