Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@spacesailor24
Copy link
Contributor

Using @web3/web3-js doesn't assign all code owners as reviewers, as was intended by the use of @web3/web3-js. Specifying all of usernames will ensure everyone is request as a reviewer for each PR that is made example of this approach

@spacesailor24 spacesailor24 added the 4.x 4.0 related label Mar 24, 2023
@spacesailor24 spacesailor24 requested a review from a team as a code owner March 24, 2023 04:52
@spacesailor24 spacesailor24 self-assigned this Mar 24, 2023
@spacesailor24 spacesailor24 mentioned this pull request Mar 24, 2023
@github-actions
Copy link

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 1.06 MB 1.06 MB 929 bytes 0.08%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 1.05 MB 1.05 MB 929 bytes 0.08%
../lib/accounts.d.ts 3.42 KB 3.42 KB 0 0.00%
../lib/types.d.ts 1.68 KB 1.68 KB 0 0.00%
../lib/types.d.ts.map 1.51 KB 1.51 KB 0 0.00%
../lib/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/index.d.ts.map 919 bytes 919 bytes 0 0.00%
../lib/index.d.ts 899 bytes 899 bytes 0 0.00%
../lib/web3.d.ts 842 bytes 842 bytes 0 0.00%
../lib/web3.d.ts.map 694 bytes 694 bytes 0 0.00%
../lib/accounts.d.ts.map 528 bytes 528 bytes 0 0.00%
../lib/eth.exports.d.ts.map 358 bytes 358 bytes 0 0.00%
../lib/eth.exports.d.ts 321 bytes 321 bytes 0 0.00%
../lib/providers.exports.d.ts.map 292 bytes 292 bytes 0 0.00%
../lib/providers.exports.d.ts 238 bytes 238 bytes 0 0.00%
../lib/version.d.ts.map 140 bytes 140 bytes 0 0.00%
../lib/abi.d.ts.map 124 bytes 124 bytes 0 0.00%
../lib/version.d.ts 97 bytes 97 bytes 0 0.00%

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8ec4b2d
Status: ✅  Deploy successful!
Preview URL: https://b672d3e2.web3-js-docs.pages.dev
Branch Preview URL: https://wyatt-4-x-update-codeowners.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #5951 (8ec4b2d) into 4.x (fef67cc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #5951   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files         137      137           
  Lines        5983     5983           
  Branches     1572     1572           
=======================================
  Hits         4899     4899           
  Misses       1084     1084           
Flag Coverage Δ
UnitTests 81.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@spacesailor24 spacesailor24 merged commit 4cfd991 into 4.x Mar 24, 2023
@spacesailor24 spacesailor24 deleted the wyatt/4.x/update-codeowners branch March 24, 2023 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4.x 4.0 related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants