This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Nikos/5931/coverage web3 abi #5934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b9bf13f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://935ae8e7.web3-js-docs.pages.dev |
| Branch Preview URL: | https://nikos-5931-coverage-web3-abi.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5934 +/- ##
==========================================
+ Coverage 81.01% 81.84% +0.82%
==========================================
Files 137 137
Lines 5984 5971 -13
Branches 1573 1571 -2
==========================================
+ Hits 4848 4887 +39
+ Misses 1136 1084 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jdevcs
reviewed
Mar 20, 2023
jdevcs
approved these changes
Mar 20, 2023
Contributor
jdevcs
left a comment
jdevcs
left a comment
There was a problem hiding this comment.
lgtm, just update changelog for formatDecodedObject . Thanks
avkos
requested review from
Muhammad-Altabba,
avkos,
luu-alex and
spacesailor24
avkos
approved these changes
Mar 20, 2023
spacesailor24
approved these changes
Mar 21, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
web3-eth-abi coverage
closes #5931