Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Web3Eth TODOs #4623

Closed
wants to merge 153 commits into from
Closed

Web3Eth TODOs #4623

wants to merge 153 commits into from

Conversation

@spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Dec 13, 2021

closes #4608

nazarhussain and others added 30 commits October 11, 2021 15:51
@nazarhussain
✨ Add Web3Config class
8910172
@nazarhussain
✨ Add configuraitons for Web3Config
d82f0ac
@nazarhussain
✅ Add unit tests for Web3Config
3f82f55
@nazarhussain
🎨 Remove unused import
18a0d43
@nazarhussain
🚨 Remove linter warnings
402d3fc
@nazarhussain
✨ Add a local storage wallet for web3-core
679c7e0
@nazarhussain
✅ Add unit tests for local storage wallet
bf90842
@nazarhussain
Add a strong type event emitter interface
9dec746
@nazarhussain
🎨 Update Web3Config to use strong type events
d0d3650
@nazarhussain
🎨 Update web3-base-provider with proper types and identity check
46307e5
@nazarhussain
🎨 Update Web3Config to use new event emitter
ccc1b3e
@nazarhussain
✨ Add Web3RequestManager class
f6db13d
@nazarhussain
Add subscription manager and subscription logic
cf29655
@nazarhussain
🚨 Fix linter warnings
b5c9efd
@nazarhussain
Merge branch 'nh/4429-request-manager' of github.com:ChainSafe/web3.j…
aef3292 
…s into nh/4429-request-manager
@nazarhussain
Merge branch '4.x' into nh/4429-request-manager
6ff4afa
@spacesailor24
Init web3-eth package
b6ce793
@spacesailor24
Merge branch 'nh/4429-request-manager' into wyatt/4.x/4483-eth-rpc-me…
6f41ea3 
…thods
@nazarhussain
🗑️ Remove a duplicate file
aef59e1
@nazarhussain
🎨 Add new error constructors
5a002b4
@nazarhussain
🎨 Update RequestManager and SubscriptionManager
8af3740
@nazarhussain
✅ Add unit tests for RequestManager and SubscriptionManager
ba2b39a
@nazarhussain
🎨 Update the exports for web3-core
ff3bf0f
@nazarhussain
🎨 Update code as per feedback
e11e103
@nazarhussain
✅ Fix failing tests
80957c5
@spacesailor24
WIP
5fa9331
@spacesailor24
Merge branch 'nh/4429-request-manager' into wyatt/4.x/4483-eth-rpc-me…
3991644 
…thods
@spacesailor24
WIP
1c0f9b9
@spacesailor24
WIP
7a250a1
@nazarhussain
🎨 Update the provider condition to set an object
c4d8f05
@spacesailor24
WIP web3_eth_methods_with_parameters.test.ts
8f59d01
@spacesailor24
WIP writing tests for web3-eth and correcting types
55494d3
@spacesailor24
Formatting
c519e5c
@spacesailor24
Add formatted transaction, receipt, and feeHistoryResult interfaces
f905d27
@spacesailor24
Init remaining tests and fixtures for methods with returnType
f5c46d8
@spacesailor24
Init tests for web3-eth methods with parameters but no returnType
c1935fa
@spacesailor24
Solve merge conflicts, ran yarn, revert eslint to ^7.32.0
76060fb
@spacesailor24
Add prefix option to isHexXBytes validation methods
0ff0e95
@spacesailor24
Refactor validateNumbersInput (break into smaller methods)
4ca1169
@spacesailor24
Init convertibleTransactionProperties
1b3e6cd
@spacesailor24
WIP transaction formatters
f851d61
@spacesailor24
Add ChainNames to Transaction interface
e10d00a
@spacesailor24
Add generic FormattedType to convertObjectPropertiesToValidType. Upda…
83b3a15 
…te web3-eth methods accordingly
@spacesailor24
Comment out estimateGas test - will be re-implemented later with tran…
f0a3cad 
…saction support in web3-eth
@spacesailor24
Update types to unknown instead of any for isValidString and isBuffer
82efb35
@spacesailor24
Remove estimateGas test - will be re-implemented later
380926f
@spacesailor24
remove normalize and fill transaction methods
1d1366c
@spacesailor24
Refactor Web3Eth to extend Web3Context
aa69a85
@spacesailor24
WIP init remaining Web3Eth methods from 1.x
8f94363
@spacesailor24 spacesailor24 added the 4.x 4.0 related label Dec 13, 2021
@spacesailor24 spacesailor24 self-assigned this Dec 13, 2021
Base automatically changed from wyatt/4.x/4483-eth-rpc-methods to 4.x December 15, 2021 21:10
@spacesailor24 spacesailor24 mentioned this pull request Jan 11, 2022
Closed
4 tasks
@github-actions
Copy link

github-actions bot commented Feb 14, 2022

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Feb 14, 2022
@mconnelly8 mconnelly8 removed the Stale Has not received enough activity label Feb 17, 2022
@spacesailor24 spacesailor24 deleted the wyatt/4.x/4608-web3-eth-todos branch August 4, 2022 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jdevcs jdevcs Awaiting requested review from jdevcs jdevcs will be requested when the pull request is marked ready for review jdevcs is a code owner

@AlexeyKrasnoperov AlexeyKrasnoperov Awaiting requested review from AlexeyKrasnoperov AlexeyKrasnoperov will be requested when the pull request is marked ready for review AlexeyKrasnoperov is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@spacesailor24 spacesailor24

Labels

4.x 4.0 related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spacesailor24 @mconnelly8 @nazarhussain