Skip to content

Commit

Permalink
fix linting issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Muhammad-Altabba committed Feb 7, 2024
1 parent fc3d121 commit bf7c170
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/web3-eth/src/web3_eth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class Web3Eth extends Web3Context<Web3EthExecutionAPI, RegisteredSubscrip
typeof providerOrContext === 'string' ||
isSupportedProvider(providerOrContext as SupportedProviders<any>)
) {
// @ts-ignore disable the error: "A 'super' call must be a root-level statement within a constructor of a derived class that contains initialized properties, parameter properties, or private identifiers."
// @ts-expect-error disable the error: "A 'super' call must be a root-level statement within a constructor of a derived class that contains initialized properties, parameter properties, or private identifiers."
super({
provider: providerOrContext as SupportedProviders<any>,
registeredSubscriptions,
Expand Down
3 changes: 2 additions & 1 deletion packages/web3-eth/test/unit/web3_eth_get_fee_data.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('Web3Eth.calculateFeeData', () => {
});

it('should return call getBlockByNumber, getGasPrice and getMaxPriorityFeePerGas', async () => {
await web3Eth.expectFeeData();
await web3Eth.calculateFeeData();
// web3Eth.getBlock = jest.fn();
expect(ethRpcMethods.getBlockByNumber).toHaveBeenCalledWith(
web3Eth.requestManager,
Expand All @@ -48,6 +48,7 @@ describe('Web3Eth.calculateFeeData', () => {

jest.spyOn(ethRpcMethods, 'getBlockByNumber').mockReturnValueOnce({ baseFeePerGas } as any);
jest.spyOn(ethRpcMethods, 'getGasPrice').mockReturnValueOnce(gasPrice as any);
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
jest
.spyOn(ethRpcMethods, 'getMaxPriorityFeePerGas')
.mockReturnValueOnce(maxPriorityFeePerGas as any);
Expand Down

2 comments on commit bf7c170

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: bf7c170 Previous: 6c075db Ratio
processingTx 9143 ops/sec (±4.08%) 9301 ops/sec (±4.81%) 1.02
processingContractDeploy 41917 ops/sec (±7.20%) 39129 ops/sec (±7.62%) 0.93
processingContractMethodSend 17715 ops/sec (±9.15%) 19443 ops/sec (±5.19%) 1.10
processingContractMethodCall 38692 ops/sec (±5.92%) 38971 ops/sec (±6.34%) 1.01
abiEncode 44656 ops/sec (±6.52%) 44252 ops/sec (±6.92%) 0.99
abiDecode 29966 ops/sec (±7.83%) 30419 ops/sec (±8.89%) 1.02
sign 1642 ops/sec (±0.56%) 1656 ops/sec (±4.08%) 1.01
verify 369 ops/sec (±0.48%) 373 ops/sec (±0.78%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: bf7c170 Previous: 6c075db Ratio
processingTx 9479 ops/sec (±5.09%) 9301 ops/sec (±4.81%) 0.98
processingContractDeploy 41053 ops/sec (±7.24%) 39129 ops/sec (±7.62%) 0.95
processingContractMethodSend 19570 ops/sec (±4.31%) 19443 ops/sec (±5.19%) 0.99
processingContractMethodCall 39482 ops/sec (±4.00%) 38971 ops/sec (±6.34%) 0.99
abiEncode 42560 ops/sec (±8.72%) 44252 ops/sec (±6.92%) 1.04
abiDecode 31272 ops/sec (±6.46%) 30419 ops/sec (±8.89%) 0.97
sign 1646 ops/sec (±1.03%) 1656 ops/sec (±4.08%) 1.01
verify 374 ops/sec (±0.68%) 373 ops/sec (±0.78%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.