Avoid PHP warnings about undefined array keys when sanitizing malformed PEMs

[crocodele]

Target branch: 4.0.x 3.4.x

• It is a Bug fix
• It is a New feature
• It is related to dependencies

Includes:

• Breaks BC
• Deprecations

When given a malformed PEM string, sanitizePEM() triggers two PHP warnings: Undefined array key 0 and Undefined array key 1.

[Spomky]

Hi,

Many thanks for this PR.
The target branch should be 3.4.x.
Also, the result of preg_match_all should be verified in a similar way to line 400

[crocodele]

Hi,

Many thanks for this PR. The target branch should be 3.4.x. Also, the result of preg_match_all should be verified in a similar way to line 400

Switched the target branch to 3.4.x and changed to checking the result of preg_match_all() and throwing an exception instead of null coalescing $matches[0][0] and $matches[0][1], in af17363.

[Spomky]

Perfect. Thanks 👍🏼
I added a test to cover this part.