Skip to content

Method "addDefaultSources" refactored #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Method "addDefaultSources" refactored #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf2fea
Method "addDefaultSources" refactored
Spomky Nov 21, 2017
83fc437
Apply fixes from StyleCI (#24)
Spomky Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 24 additions & 32 deletions src/Bundle/JoseFramework/DependencyInjection/JoseFrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,41 +122,33 @@ private function addDefaultSources()
if (class_exists(JKUSource::class) && class_exists(HttplugBundle::class)) {
$this->addSource(new JKUSource());
}
if (class_exists(JWKSource::class)) {
$this->addSource(new JWKSource());
}
if (class_exists(JWKUriSource::class)) {
$this->addSource(new JWKUriSource());
}
if (class_exists(JWKSetSource::class)) {
$this->addSource(new JWKSetSource());
}
if (class_exists(ClaimChecker::class)) {
$this->addSource(new ClaimChecker());
}
if (class_exists(HeaderChecker::class)) {
$this->addSource(new HeaderChecker());
}
if (class_exists(JWSBuilder::class)) {
$this->addSource(new JWSBuilder());
}
if (class_exists(JWSSerializer::class)) {
$this->addSource(new JWSSerializer());
}
if (class_exists(JWSVerifier::class)) {
$this->addSource(new JWSVerifier());
}
if (class_exists(JWEBuilder::class)) {
$this->addSource(new JWEBuilder());
}
if (class_exists(JWEDecrypter::class)) {
$this->addSource(new JWEDecrypter());
}
if (class_exists(JWESerializer::class)) {
$this->addSource(new JWESerializer());
foreach ($this->getSourceClasses() as $class) {
if (class_exists($class)) {
$this->addSource(new $class());
}
}
}

/**
* @return string[]
*/
private function getSourceClasses(): array
{
return [
JWKSource::class,
JWKUriSource::class,
JWKSetSource::class,
ClaimChecker::class,
HeaderChecker::class,
JWSBuilder::class,
JWSSerializer::class,
JWSVerifier::class,
JWEBuilder::class,
JWEDecrypter::class,
JWESerializer::class,
];
}

/**
* {@inheritdoc}
*/
Expand Down