[Bugfix] Fix JWE serialiser crashing by invalid typehint ⚠️ #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JWE serialiser crashes when attempting to decode invalid data or even a JWS. The serialiser returns null but checkData does not accept a null value and throws an exception.
mdeboer
changed the title
mdeboer
changed the title
mdeboer
changed the title
Member
|
Sorry. My mistake. |
Contributor
Author
|
No worries, thanks for merging! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JWE serialiser crashes when attempting to decode invalid data or even a valid JWS. The JSON serialiser returns null but checkData does not accept a null value and throws an exception as it's typehinted with array.
The v1.3 branch had a
is_arraycheck here which was removed inv2.0but this also prevented null values.