-
-
Notifications
You must be signed in to change notification settings - Fork 117
Closed
Labels
DXDependenciesPull requests that update a dependency filePull requests that update a dependency fileUX
Milestone
Description
ext-gmp is only used for few and not standard features, and in some packages is required even if not necessary.
For example, jwt-key-mgmt requires the gmp extension, but it's only used for some key analyzers.
It would be better to:
- remove
ext-gmpas a hard dependency when not necessary, introducing some check like:public function analyze(JWK $jwk, MessageBag $bag): void { if (! \extension_loaded('gmp')) { throw new \LogicException(static::class . ' requires gmp extension'); } // ... }
jwt-corejwt-key-mgmt
- add
ext-gmpas a hard dependecy when necessary:jwt-encryption-algorithm-ecdh-esjwt-util-ecc
SpomkySpomky
Metadata
Metadata
Assignees
Labels
DXDependenciesPull requests that update a dependency filePull requests that update a dependency fileUX