Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecurityContext logic. #133

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Add SecurityContext logic. #133

merged 6 commits into from
Nov 16, 2023

Conversation

jfclere
Copy link
Contributor

@jfclere jfclere commented Nov 14, 2023

Add SecurityContext logic and support info message about error when no error.

@vassilismourikis
Copy link
Collaborator

I see failure during building

Run KUBEBUILDER_ASSETS=/usr/local/bin go test -timeout 60m ./... -coverprofile cover.out

github.com/web-servers/jws-operator/controllers

Error: controllers/templates.go:749:61: webServer.Spec.SecurityContext undefined (type "github.com/web-servers/jws-operator/api/v1alpha1".WebServerSpec has no field or method SecurityContext)
FAIL github.com/web-servers/jws-operator/controllers [build failed]
Error: Process completed with exit code 2.

@jfclere
Copy link
Contributor Author

jfclere commented Nov 14, 2023

I see failure during building

Run KUBEBUILDER_ASSETS=/usr/local/bin go test -timeout 60m ./... -coverprofile cover.out

github.com/web-servers/jws-operator/controllers

Error: controllers/templates.go:749:61: webServer.Spec.SecurityContext undefined (type "github.com/web-servers/jws-operator/api/v1alpha1".WebServerSpec has no field or method SecurityContext) FAIL github.com/web-servers/jws-operator/controllers [build failed] Error: Process completed with exit code 2.

Oops missing api/v1alpha1/webserver_types.go in commit.

@vassilismourikis
Copy link
Collaborator

LGTM

Arrange /deployment/tmp to /tmp/tmp.xml as /deployment is not writable.
@vassilismourikis vassilismourikis merged commit b68744f into web-servers:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants