python: nose -> pytest #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
reviewed
Jul 29, 2024
|
Hi! Thanks for this. I'll be honest, I kinda forgot about this library, so my apologies for not keeping things up-to-date. The config changes are mostly just to prevent anything that might be scanning the test output from breaking. If there are things you can't replicate, I'm not going to force the issue. |
13 tasks
|
I've updated the commit, so that the pytest.ini should now be fully in-line with the former .noserc configuration. |
jrconlin
approved these changes
Jul 29, 2024
|
Gonna give @martinthomson a chance to look this over (He's on AUNZ time so ~+12), but I'll merge these soon. Thanks! |
|
Right, so 1.2.1 is ready to go, but I don't have access to https://pypi.org/project/http-ece/, so @martinthomson will have to push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the python testing suite from the deprecated nose test runner to pytest. Besides the dependencies, there are as few changes to the code as possible, to ensure that test behavior has not changed. I've checked, and all tests pass on python 3.9+, but I don't have any 2.7 or 3.8 environments to test on at the moment.