Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webappsec-credential-management IDL file #9844

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 March 5, 2018 19:09
@ghost
Copy link

ghost commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 08:02:34
Finished: 2018-03-08 08:11:32

View more information about this build on:

@lukebjerring lukebjerring force-pushed the idl-file-updates-webappsec-credential-management branch from 909686e to c644d41 Compare March 7, 2018 20:32
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mikewest mikewest merged commit 89e834c into web-platform-tests:master Jun 28, 2018
lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 29, 2018
…ts#9844)

* Add webappsec-credential-management idl file

* Updated webappsec-credential-management IDL file

* Clean up tests
@lukebjerring lukebjerring deleted the idl-file-updates-webappsec-credential-management branch October 5, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants