Fix lazy media in-viewport tests to check loadeddata instead of loadsstart#58405
Open
scottjehl wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
Fix lazy media in-viewport tests to check loadeddata instead of loadsstart#58405scottjehl wants to merge 1 commit intoweb-platform-tests:masterfrom
scottjehl wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
…tart The loadstart event has no ordering guarantee relative to the window load event. Intersection observer callbacks can fire before or after the load event, and media elements use their own task source, so loadstart may be dispatched before window load. The trickle(d2) pipe ensures slow media delivery, so checking loadeddata (which fires after enough data arrives to render the first frame) reliably verifies that window onload is not blocked by lazy media elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loadstart event has no ordering guarantee relative to the window load event. Intersection observer callbacks can fire before or after the load event, and media elements use their own task source, so loadstart may be dispatched before window load.
The trickle(d2) pipe ensures slow media delivery, so checking loadeddata (which fires after enough data arrives to render the first frame) reliably verifies that window onload is not blocked by lazy media elements.