script: Fix fetch-later length and quota computation #56978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 4, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_41665
branch
from
27dd3ce to
59dbdf4
Compare
The specification isn't complete here and thus we were missing WPT coverage. Spec will be updated. Also, we are correctly throwing the QuotaExceededError with relevant information, while Chrome sets both fields to `null`. Therefore, the test now allows for both (since providing relevant information is good for the developer and recommended in the spec [1]). [1]: https://webidl.spec.whatwg.org/#ref-for-quotaexceedederror%E2%91%A2 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
force-pushed
the
servo_export_41665
branch
from
59dbdf4 to
f8457d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification isn't complete here and thus we
were missing WPT coverage. Spec will be updated.
Also, we are correctly throwing the QuotaExceededError with relevant information, while Chrome sets both
fields to
null. Therefore, the test now allows for both (since providing relevant information is good for the developer and recommended in the spec 1).Reviewed in servo/servo#41665