Digital credentials: move permissions policy files #56404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the digital credentials permissions policy test files by moving them from a shared /permissions-policy/resources/ directory into the /digital-credentials/permissions-policy/ subdirectory. This change addresses a WebKit import workflow limitation where only one directory is imported at a time, preventing files from getting out of sync.
- Adds two new test helper files for permissions policy testing in the digital-credentials directory
- Updates all path references across four test files to point to the new location
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
digital-credentials/permissions-policy/get.html |
New iframe helper for testing digital credentials get() API with permissions policy |
digital-credentials/permissions-policy/create.html |
New iframe helper for testing digital credentials create() API with permissions policy |
digital-credentials/get.disabled-by-permissions-policy.https.sub.html |
Updated path reference from /permissions-policy/resources/ to /digital-credentials/permissions-policy/ |
digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html |
Updated both get and create path references to new location |
digital-credentials/default-permissions-policy.https.sub.html |
Updated both get and create path references to new location |
digital-credentials/create.disabled-by-permissions-policy.https.sub.html |
Updated path reference from /permissions-policy/resources/ to /digital-credentials/permissions-policy/ |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mohamedamir
approved these changes
Dec 2, 2025
Contributor
mohamedamir
left a comment
mohamedamir
left a comment
There was a problem hiding this comment.
I tried to search in the code base to find precedence but I couldn't find any.
But I think it's a reasonable change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WebKit, we generally only import one directory at a time, so having things in multiple directories means things get out of sync easily.