Add tests for redacted location.ancestorOrigins https://github.com/whatwg/html/pull/11560 #56224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
reviewed
Nov 25, 2025
...browsers/history/the-location-interface/resources/location-ancestor-origins-create-iframe.js
Outdated
Show resolved
Hide resolved
...ers/history/the-location-interface/resources/location-ancestor-origins-recursive-iframe.html
Show resolved
Hide resolved
...ers/history/the-location-interface/resources/location-ancestor-origins-recursive-iframe.html
Outdated
Show resolved
Hide resolved
...ers/history/the-location-interface/resources/location-ancestor-origins-recursive-iframe.html
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestor-origins.sub.html
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestor-origins.tentative.sub.html
Outdated
Show resolved
Hide resolved
6 tasks
theIDinside
force-pushed
the
redacted-ancestor-origins-tests
branch
from
3b36668 to
1357a38
Compare
zcorpan
reviewed
Dec 4, 2025
html/browsers/history/the-location-interface/location-ancestor-origins.sub.html
Outdated
Show resolved
Hide resolved
zcorpan
reviewed
Dec 4, 2025
...ers/history/the-location-interface/resources/location-ancestor-origins-recursive-iframe.html
Outdated
Show resolved
Hide resolved
theIDinside
force-pushed
the
redacted-ancestor-origins-tests
branch
from
1357a38 to
b81b1b0
Compare
- Tests toggling of 'masked' in the algorithm. - Tests mutating policy on iframe and then having a grandchild browsing context be created. - Tests sandboxing so that all origins become null below it.
theIDinside
force-pushed
the
redacted-ancestor-origins-tests
branch
from
b81b1b0 to
2d6e76c
Compare
Contributor
Author
|
I added about:blank tests to this WPT, as they were useful when implementing this feature in Gecko. Technically, from a spec perspective an about:blank or a normal document aren't different, but there could be implementation details that can make these tests useful. Should we keep it or should I move it to a gecko-only repo? |
Member
|
Let's keep the about:blank tests in wpt. |
zcorpan
approved these changes
Dec 8, 2025
Member
|
Marking this |
Member
|
wpt sync PR #56685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test written for the redacted location.ancestorOrigins spec.
Addresses all examples described in the PR for the spec in whatwg/html#11560.
Filed as a PR here because it was requested by @domfarolino to be able to comment on it.
Beyond the requested tag of loosening/tightening policy as requested by @domfarolino also added that doing this, should not affect grandchildren.
Test cases written in a declarative fashion:
description, frames: { name, src, iframeReferrerPolicy, options }[] , expected: string []
options is an object of: { sandbox?, target?, action?, value? }
Used to configure if the iframe should have the sandbox attribute.
target&&action&&valueis used to configure an iframe with a new attribute, or do something inside of a frame (target), like inserting a meta element.The reason for there being 3 iframes, instead of just 2, is to avoid changing anything in the top level document, which could potentially affect subsequent tests after it. This way, tear down is clean and simple between test cases.