[testdriver] Add testdriver extension for prefetch event in speculation module #55274
Conversation
…t and infrastructure tests
wpt-pr-bot
added
infra
testdriver.js
webdriver-bidi
wg-s_browser-tools-testing
wptrunner
wpt-pr-bot
requested review from
AutomatedTester,
DanielRyanSmith,
foolip,
jgraham,
jonathan-j-lee,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
…b.com/srwei/wpt into SpeculationRulesPrefetchWebDriverBidi
|
Please add wdspec tests as well. Actually, I'd prefer to have wdspec tests first in a separate PR, but it's up to you. |
infrastructure/testdriver/bidi/speculation/prefetch_status_updated.https.html
Outdated
Show resolved
Hide resolved
infrastructure/testdriver/bidi/speculation/prefetch_status_updated.https.html
Outdated
Show resolved
Hide resolved
Oh I thought webdriver/tests/bidi/external/speculation/prefetch_status_updated/ tests were the wdpsec tests |
infrastructure/testdriver/bidi/speculation/prefetch_status_updated.https.html
Outdated
Show resolved
Hide resolved
|
Closing and opening to re-run CI |
sadym-chromium
left a comment
sadym-chromium
left a comment
There was a problem hiding this comment.
Sorry, forgot to publish the comment
There was a problem hiding this comment.
Please update expectation for the test for none-chromium browsers. Please refer to https://github.com/web-platform-tests/wpt/blob/master/infrastructure/metadata/infrastructure/testdriver/bidi/emulation/set_geolocation_override.https.html.ini, as a part of #52128.
There was a problem hiding this comment.
Thank you! Looks like all checks are passing now
…b.com/srwei/wpt into SpeculationRulesPrefetchWebDriverBidi
|
@web-platform-tests/wpt-core-team please review |
|
Please patient me |
|
@jcscottiii could you please take a look? |
| const subscription_id = action_result["subscription"]; | ||
|
|
||
| return async ()=>{ | ||
| console.log("!!@@## unsubscribing") |
There was a problem hiding this comment.
Yeah, removing this seems like a good idea, sure looks like frustrated debugging left in :)
8 participants
Spec: https://wicg.github.io/nav-speculation/prefetch.html#automated-testing
chromium-bidi implementation: GoogleChromeLabs/chromium-bidi@66d3585
Adding testdriver extension for the speculation module that is mainly to add the prefetch_status_updated event. No commands.
This event will replace the current timeout mechanism for speculation rules prefetch in the wpt prefetch corpus: https://github.com/web-platform-tests/wpt/tree/master/speculation-rules/prefetch
Follow up CLs will be raised to update the above tests to use the new event handling.
@sadym-chromium would you be able to help with rollover for chromium?