ancestorOrigins #5402
ancestorOrigins #5402
Conversation
|
These are tests for whatwg/html#2480 per scenarios at w3c/webappsec-referrer-policy#77 (comment). |
|
Apologies for the readability by the way. It was somewhat hard to balance that with not copying-and-pasting too much. |
Also rewrite the algorithm to avoid loops and use variables correctly. Tests: web-platform-tests/wpt#5402. Fixes #1918.
html/browsers/history/the-location-interface/location-ancestororigins-involved.html
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestororigins-involved.html
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestororigins-involved.html
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestororigins-involved.html
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestororigins-involved.html
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestororigins.html
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestororigins.html
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/location-ancestororigins.html
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/resources/ancestororigins-embed.py
Outdated
Show resolved
Hide resolved
html/browsers/history/the-location-interface/resources/ancestororigins-embed.py
Outdated
Show resolved
Hide resolved
|
There are no tests for non-ASCII stuff in here. There probably should be some, given whatwg/html#2480 (comment) |
annevk
force-pushed
the
annevk/html-ancestororigins
branch
from
e057758 to
adfd687
Compare
|
I addressed the substantive feedback other than a ToUnicode test as it's unclear to me what we should do there per whatwg/html#2568. I haven't addressed style feedback as I'm not inconsistent and there's no style guide for this project. And getting PRs through sometimes and sometimes not for that reason doesn't scale and would be frustrating for contributors. |
annevk
force-pushed
the
annevk/html-ancestororigins
branch
from
afa70a9 to
453e886
Compare
|
Depending on ASI is not "style". It's a bug, because it leads to extremely fragile code.... As in, I cannot vouch for the correctness of any code you ask me to review that depends on ASI. Maybe it does what you think, maybe not. |
annevk
force-pushed
the
annevk/html-ancestororigins
branch
from
453e886 to
f0d3e4c
Compare
|
@jugglinmike hitting Edge issues again it seems like. |
Also rewrite the algorithm to avoid loops and use variables correctly. Tests: web-platform-tests/wpt#5402. Fixes #1918.
Also rewrite the algorithm to avoid loops and use variables correctly. Tests: web-platform-tests/wpt#5402. Fixes #1918.
annevk
force-pushed
the
annevk/html-ancestororigins
branch
from
4095044 to
0e5179b
Compare
|
I think I addressed all feedback now. |
See whatwg/html#1918 for the HTML Standard discussion and whatwg/html#2480 for the HTML Standard change.
zcorpan
force-pushed
the
annevk/html-ancestororigins
branch
from
48a297b to
9c803ad
Compare
|
I've rebased this (without making changes). The new spec PR is whatwg/html#11560 I think most (if not all) of these tests should have the same expected result with the new algorithm. I'll take a closer look and maybe add a few more tests that would produce different results. |
|
This is superseded by the tests in https://phabricator.services.mozilla.com/D273393 (all cases tested in this PR should be covered, and then some). |
No description provided.