[testharness.js] Fix issue caused when path contains full stop characters (.) #50695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Feb 14, 2025
That should be possible. I’ll add a test to this PR over the weekend. |
…ters (.) web-platform-tests#50693 The current implementation of `get_title()` assumes that the path does not contain a full stop character. If it does, `get_title()` would return parts of the path, in stead of the filename. The pathname `/a.path/filename.html` would cause `get_title()` to return `.path` instead of the expected `filename`. This change fixes the issue by trimming the path away before searching for the extension. It maintains the current behavior, where it only keeps the first part of the filename if the filename contains multiple full stop characters. `/path/filename.foo.html` still returns `filename`.
johannesodland
force-pushed
the
return-filename-when-path-contains-full-stop
branch
from
d23a849 to
d298c10
Compare
|
Added a test to assert that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50693
The current implementation of
get_title()assumes that the path does not contain a full stop character. If it does,get_title()would return parts of the path, in stead of the filename. The pathname/a.path/filename.htmlwould causeget_title()to return.pathinstead of the expectedfilename.This change fixes the issue by trimming the path away before searching for the extension. It maintains the current behavior, where it only keeps the first part of the filename if the filename contains multiple full stop characters.
/path/filename.foo.htmlstill causesfilenameto be returned.