Do not guess UTF8 encoding #4899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the text encoding detector return false if the detected encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers to neglect proper encoding labelling and rely on browser-side encoding detection. This CL helps prevent that. BUG=691985 Review-Url: https://codereview.chromium.org/2697213002 Cr-Commit-Position: refs/heads/master@{#451194}
Collaborator
|
Notifying @gsnedders. (Learn how reviewing works.) |
Chrome (unstable channel)Testing web-platform-tests at revision 14631d5d68e0fd22422903553a6edb04e17fd5a1 |
Firefox (nightly channel)Testing web-platform-tests at revision 14631d5d68e0fd22422903553a6edb04e17fd5a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the text encoding detector return false if the detected
encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers
to neglect proper encoding labelling and rely on browser-side encoding
detection. This CL helps prevent that.
BUG=691985
Review-Url: https://codereview.chromium.org/2697213002
Cr-Commit-Position: refs/heads/master@{#451194}