[Gecko Bug 1876762] Implement togggle events for Dialog show/showModal/close#48601
Merged
Conversation
whatwg/html#10091 This also slightly refactors FireToggleEvent to allow to to accomodate both popovers and now also dialogs Differential Revision: https://phabricator.services.mozilla.com/D225449 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876762 gecko-commit: a8b51403fa4f1dd6d936826f2a5b14c670426f3d gecko-reviewers: smaug
wpt-pr-bot
approved these changes
Oct 14, 2024
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whatwg/html#10091
This also slightly refactors FireToggleEvent to allow to to
accomodate both popovers and now also dialogs
Differential Revision: https://phabricator.services.mozilla.com/D225449
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876762
gecko-commit: a8b51403fa4f1dd6d936826f2a5b14c670426f3d
gecko-reviewers: smaug