Skip to content

Conversation

@jungkees
Copy link
Contributor

@jungkees jungkees commented Feb 9, 2017

To reflect the spec change (w3c/ServiceWorker@9e68720), remove code related to FetchEvent.isReload attribute.

To reflect the spec change (w3c/ServiceWorker@9e68720), remove code related to FetchEvent.isReload attribute.
@wpt-pr-bot
Copy link
Collaborator

Notifying @ehsan and @mkruisselbrink. (Learn how reviewing works.)

These tests will be available on w3c-test.org shortly after they are approved by a repository collaborator.

@jungkees
Copy link
Contributor Author

jungkees commented Feb 9, 2017

Stub files seem to be not up-to-date, but just changed isReload attribute related part in this PR.

@ghost
Copy link

ghost commented Feb 9, 2017

Chrome (unstable channel)

Testing web-platform-tests at revision 23ec409
Using browser at version 58.0.3004.3 dev
Starting 10 test iterations
All results were stable

All results

/service-workers/service-worker/interfaces.https.html
Subtest Results
ERROR
Cache PASS
Interfaces and attributes of ServiceWorkerContainer PASS
Interfaces and attributes of ServiceWorker PASS
CacheStorage PASS
Clients PASS
Event constructors PASS
Interfaces and attributes in ServiceWorkerGlobalScope PASS
Client PASS
WindowClient PASS
ServiceWorkerGlobalScope PASS

@ghost
Copy link

ghost commented Feb 9, 2017

Firefox (nightly channel)

Testing web-platform-tests at revision 23ec409
Using browser at version BuildID 20170123125947; SourceStamp 36486fdc3813ef7943ae5b07b4128866d1938a6c
Starting 10 test iterations
All results were stable

All results

/service-workers/service-worker/interfaces.https.html
Subtest Results
OK
Cache PASS
Interfaces and attributes of ServiceWorkerContainer PASS
Interfaces and attributes of ServiceWorker PASS
CacheStorage PASS
Clients PASS
Event constructors PASS
Interfaces and attributes in ServiceWorkerGlobalScope PASS
Client PASS
WindowClient PASS
ServiceWorkerGlobalScope PASS

@mkruisselbrink
Copy link
Contributor

It's probably a good idea to add a test to make sure FetchEvent doesn't have an isReload attribute (like the various other historical.html tests various directories contain)?

@RByers
Copy link
Contributor

RByers commented Feb 9, 2017

w3c-test:mirror

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants