Add failing COOP noopener-allow-popups tests and flags #46979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL adds the flags and failing tests for [1], to clearly separate them from the functional changes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5581251 Bug: 344963946 Change-Id: I1320fd6893a3ba25d93f89efd5a30e151a69889b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640893 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1322722}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5640893
branch
from
07a085a to
04435bd
Compare
wpt-pr-bot
approved these changes
Jul 3, 2024
|
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
|
@DanielRyanSmith @KyleJu Pinged bug about the new timeout: https://crbug.com/344963946#comment4. Please force merge, thanks! |
KyleJu
approved these changes
Jul 8, 2024
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] #46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 9, 2024
Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] web-platform-tests/wpt#46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687771 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324852}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] #46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687771 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324852}
KyleJu
pushed a commit
that referenced
this pull request
Jul 10, 2024
…47054) Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] #46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687771 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324852} Co-authored-by: Yoav Weiss <yoavweiss@chromium.org>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 15, 2024
…nd flaky null check from WPT, a=testonly Automatic update from web-platform-tests COOP noopener: Remove the non-standard and flaky null check from WPT (#47054) Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] web-platform-tests/wpt#46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687771 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324852} Co-authored-by: Yoav Weiss <yoavweiss@chromium.org> -- wpt-commits: 5c042c8a1ee8b94ef624448f25d134d1d44f0843 wpt-pr: 47054
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 16, 2024
…nd flaky null check from WPT, a=testonly Automatic update from web-platform-tests COOP noopener: Remove the non-standard and flaky null check from WPT (#47054) Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] web-platform-tests/wpt#46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687771 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324852} Co-authored-by: Yoav Weiss <yoavweiss@chromium.org> -- wpt-commits: 5c042c8a1ee8b94ef624448f25d134d1d44f0843 wpt-pr: 47054
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 18, 2024
…nd flaky null check from WPT, a=testonly Automatic update from web-platform-tests COOP noopener: Remove the non-standard and flaky null check from WPT (#47054) Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] web-platform-tests/wpt#46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687771 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324852} Co-authored-by: Yoav Weiss <yoavweiss@chromium.org> -- wpt-commits: 5c042c8a1ee8b94ef624448f25d134d1d44f0843 wpt-pr: 47054
sadym-chromium
pushed a commit
that referenced
this pull request
Jul 18, 2024
This CL adds the flags and failing tests for [1], to clearly separate them from the functional changes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5581251 Bug: 344963946 Change-Id: I1320fd6893a3ba25d93f89efd5a30e151a69889b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640893 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1322722} Co-authored-by: Yoav Weiss <yoavweiss@chromium.org>
sadym-chromium
pushed a commit
that referenced
this pull request
Jul 18, 2024
…47054) Given the fact that the null check in COOP noopener's WPTs is non-standard [1] and flaky [2], it's better to remove it for now. [1] whatwg/html#10457 [2] #46979 (comment) Bug: 344963946 Change-Id: I0bc0e7d153cc400938079a9d12209f57ea8310fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687771 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324852} Co-authored-by: Yoav Weiss <yoavweiss@chromium.org>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds the flags and failing tests for [1], to clearly separate
them from the functional changes.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/5581251
Bug: 344963946
Change-Id: I1320fd6893a3ba25d93f89efd5a30e151a69889b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640893
Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322722}