WebNN: Support axis for softmax operator#46725
Merged
Merged
Conversation
This CL adds axis parameter into the IDL and mojo definitions of softmax operator [1]. It also updates the backends implementation to support the new axis parameter. In addition, the corresponding tests have also been updated. [1] webmachinelearning/webnn#649 Bug: 338094927 Change-Id: Ib08ecbba61c27c94256953a952357eeda80241e6 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5495877 Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1314418}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5495877
branch
from
1c76a91 to
f452533
Compare
wpt-pr-bot
approved these changes
Jun 13, 2024
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds axis parameter into the IDL and mojo definitions of softmax
operator [1]. It also updates the backends implementation to support the
new axis parameter.
In addition, the corresponding tests have also been updated.
[1] webmachinelearning/webnn#649
Bug: 338094927
Change-Id: Ib08ecbba61c27c94256953a952357eeda80241e6
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5495877
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1314418}